Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a data race in notifier packaging #5892

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Fix a data race in notifier packaging #5892

merged 1 commit into from
Sep 27, 2022

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Sep 26, 2022

CollectionNotifier::version() requires holding RealmCoordinator::m_notifier_mutex, which was being violated in a few places.

@tgoyne tgoyne self-assigned this Sep 26, 2022
@cla-bot cla-bot bot added the cla: yes label Sep 26, 2022
bmunkholm
bmunkholm reviewed Sep 26, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
bmunkholm
bmunkholm reviewed Sep 26, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tgoyne
Fix a data race in notifier packaging
b1df6f8 
CollectionNotifier::version() requires holding
RealmCoordinator::m_notifier_mutex, which was being violated in a few places.
@tgoyne tgoyne force-pushed the tg/notifier-data-race branch from 7128223 to b1df6f8 Compare September 26, 2022 22:05
@tgoyne tgoyne requested a review from ironage September 27, 2022 15:09
@tgoyne tgoyne merged commit 18582a8 into master Sep 27, 2022
@tgoyne tgoyne deleted the tg/notifier-data-race branch September 27, 2022 17:53
tgoyne added a commit that referenced this pull request Sep 27, 2022
@tgoyne
Merge remote-tracking branch 'origin/master' into feature/exception-u…
eb06da5 
…nification

* origin/master:
  Fix a data race in notifier packaging (#5892)
  Install util/http.hpp (#5893)
  Greatly improve performance of sorting dictionaries (#5168)
  Sync client shall not block user writes (#5844)
  update err message check (#5884)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmunkholm bmunkholm bmunkholm left review comments

@ironage ironage ironage approved these changes

Assignees

@tgoyne tgoyne

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgoyne @bmunkholm @ironage